-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitigate relative path calculation error on multiple iterations #2095
Conversation
The following pipelines have been queued for testing: |
@@ -48,8 +48,15 @@ function SetOutput($outputPath, $incomingPackageSpec) { | |||
else | |||
{ | |||
$outputObject = $incomingPackageSpec | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this can we instead fix the GetRelativePath logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually update the logic in Package-Properties to make the path relative from the beginning.
This reverts commit 45baedd.
…ng [IO.Path]::GetRelativePath
462b265
to
4df21ff
Compare
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@praveenkuttappan @weshaggard
This change mitigates an obscure issue we ran into after the change to
Save-Package-Properties.ps1
merged. It would seem that the relative path computation will, on DevOps machines, generate relative paths with an extra../
prepended unnecessarily.Mitigates #2094