Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate relative path calculation error on multiple iterations #2095

Merged
3 commits merged into from
Oct 13, 2021
Merged

Mitigate relative path calculation error on multiple iterations #2095

3 commits merged into from
Oct 13, 2021

Conversation

danieljurek
Copy link
Member

@praveenkuttappan @weshaggard

This change mitigates an obscure issue we ran into after the change to Save-Package-Properties.ps1 merged. It would seem that the relative path computation will, on DevOps machines, generate relative paths with an extra ../ prepended unnecessarily.

Mitigates #2094

@danieljurek danieljurek requested a review from a team as a code owner October 12, 2021 18:22
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

Testing succeeds:

I'll merge

This was referenced Oct 12, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard reviewed Oct 12, 2021
View reviewed changes
eng/common/scripts/Save-Package-Properties.ps1 Outdated
@@ -48,8 +48,15 @@ function SetOutput($outputPath, $incomingPackageSpec) {
else
{
$outputObject = $incomingPackageSpec

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this can we instead fix the GetRelativePath logic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually update the logic in Package-Properties to make the path relative from the beginning.

@danieljurek danieljurek force-pushed the save-package-properties-paths-once branch from 462b265 to 4df21ff Compare October 13, 2021 03:58
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

Running checks on new code based on review feedback:

@ghost
Copy link

ghost commented Oct 13, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 722dda3 into Azure:main Oct 13, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danieljurek @azure-sdk @weshaggard @praveenkuttappan